coala / landing-frontend

coala Landing Page - https://gitlab.com/coala/landing is needed as backend
https://coala.io/
GNU Affero General Public License v3.0
32 stars 74 forks source link

Added copy to clipboard functionality #287

Closed abhishalya closed 5 years ago

abhishalya commented 5 years ago

Added "copy to clipboard" button to copy code snippets.

Fixes #69

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

abhishalya commented 5 years ago

@Man-Jain The url is obviously incorrect :sweat_smile: I wen't through commit guidelines. Can you give me some example of what ideal commit message should be here. Would "Added single button to allow users to copy code snippets to clipboard" work?

Man-Jain commented 5 years ago

@Man-Jain The url is obviously incorrect I wen't through commit guidelines. Can you give me some example of what ideal commit message should be here. Would "Added single button to allow users to copy code snippets to clipboard" work?

Well you can do

coalaonline.html: Add copy to clipboard button

Or something similar you like

abhishalya commented 5 years ago

@Man-Jain Would this work?

Man-Jain commented 5 years ago

@Man-Jain Would this work?

Nope, did you read the commit guidelines? Commit message must contain the issue link. Also a description must be added in your case

abhishalya commented 5 years ago

@Man-Jain Oops, I have added the required things now. Can you check?

jayvdb commented 5 years ago

ack https://github.com/coala/landing-frontend/pull/287/commits/89ab69cf410ece81359f89b36c6ab772f713ffb2

jayvdb commented 5 years ago

@gitmate-bot ff

jayvdb commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

jayvdb commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: