cobyism / ghost-on-heroku

One-button Heroku deploy for the Ghost blogging platform.
MIT License
743 stars 686 forks source link

NPM 5.4.x error (Cannot read property 'pause' of undefined) #127

Closed jevawin closed 6 years ago

jevawin commented 7 years ago

NPM 5.4.x has introduced a bug, which is blocking the deployment process because Heroku defaults to the latest version of NPM.

This can be fixed by locking NPM 5.3.0 in package.json.

"engines": {
    "node": "^4.8.4 || ^6.11.1",
    "npm": "5.3.0"
  },

I'm not sure how to do pull requests so I'm just opening an issue so you guys are aware of the issue and how to fix it :-)

eduarmreyes commented 7 years ago

Thanks, really helped me on this one

cobyism commented 7 years ago

Thanks for the report. If this is affecting everyone, it might be worth opening a PR to add this, however if it’s not going to be a permanent or widespread issue I’d prefer to keep our package.json as aligned as possible with the TryGhost/ghost one (which doesn’t specify an NPM version).

mars commented 6 years ago

Heroku itself implemented an automatic build workaround for this npm version’s bug.