search

cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11.3k stars 1.12k forks source link

In Firefox, favicon does not appear in the bookmarks bar, even though it appears in the tab bar #17915

Open SinTan1729 opened 2 years ago

SinTan1729 commented 2 years ago

Explain what happens

To reproduce

  1. Open the website for a local cockpit installation
  2. Add it to bookmarks bar

Note that the issue only happens in Firefox, Chromium based browsers behave as expected. I opened an issue in their forum, but it looks like it's the intended behavior. Here's a link to the issue.

Screenshot

Version of Cockpit

264.2

Where is the problem in Cockpit?

Unknown or not applicable

Server operating system

other

Server operating system version

AlmaLinux 9

What browsers are you using?

Firefox

System log

No response

garrett commented 2 years ago

The result of the issue @ https://bugzilla.mozilla.org/show_bug.cgi?id=1800036 is that we're not setting the favicon outside of JavaScript.

A quick peek at the generated HTML shows:

We'd want to set both.

Looking at the visual icon in the tab when logged out and logged in, I see a Fedora icon. So we're setting it via JavaScript to the logo of the distribution. We need to either use the distribution icon (which we have no control over, I think) or the Cockpit icon (although we generally try to not show Cockpit, but present as a distribution's UI).

This means, we'd want to tailor the HTML that gets sent to the browser. And that very likely means compilation / build system changes, especially for the login page. (Can we use the same filename regardless of distribution? That should make things easier, I'd think.)

garrett commented 2 years ago

@SinTan1729: BTW: Thanks for digging into this and filing an issue with Mozilla and with us here!