search

cockroachdb / cockroach-go

Packages for go clients.
Apache License 2.0
160 stars 70 forks source link

Upgrade GORM helper to use GORM v2 #94

Closed rafiss closed 4 years ago

rafiss commented 4 years ago

We are using https://github.com/jinzhu/gorm which is not maintained now.

The project is now at https://github.com/go-gorm/gorm

markdiener10 commented 4 years ago

Hello Rafiss. I see you are taking my suggestion at upgrading the library from this mornings meeting notes.

xuhui-lu commented 4 years ago

hello @rafiss , I am a junior contributor in cockroachdb community. May I get a chance to work on this issue?

rafiss commented 4 years ago

@xuhui-lu sure, we would welcome and appreciate your contribution!

markdiener10 commented 4 years ago

Rafiss, you can grab the commit from 28 days ago, I changed the cockroach-go to use GORM v2. You just need to talk to the people from our project meeting.

xuhui-lu commented 4 years ago

oh, so is this issue solve already?

rafiss commented 4 years ago

@markdiener10 Thanks for the reminder! :) Unfortunately I won't have the time to coordinate with the people from that meeting about getting the code.

We'd welcome a PR on this issue. I'll be able to review the code once something is submitted here. So @xuhui-lu we would still welcome your contribution.

markdiener10 commented 4 years ago

Let me see what I can do.

xuhui-lu commented 4 years ago

cool, thanks for the info.

xuhui-lu commented 4 years ago

@rafiss I just submitted a PR for this issue, could you help me review it?

rafiss commented 4 years ago

closed by #95