cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.17k stars 3.82k forks source link

admission: async compaction cause disk bandwidth spikes #132332

Open aadityasondhi opened 1 month ago

aadityasondhi commented 1 month ago

We noticed in https://github.com/cockroachdb/cockroach/issues/131484#issuecomment-2397597539 that async compactions in pebble cause spikes in disk bandwidth, ultimately leading to the assertion failure since the disk bandwidth limiter cannot account for these reads and writes until after the 15s adjustment interval.

We can attribute these writes as error term in our write amp linear model and should account for them at a higher frequency. We discussed the implementation of such accounting internally.

Jira issue: CRDB-42982

Epic CRDB-37479

blathers-crl[bot] commented 1 month ago

Hi @aadityasondhi, please add branch-* labels to identify which branch(es) this C-bug affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.