opt: reoptimize main query with scalar subquery results

[xinyuliu12]

Hello everyone!

First off, I am sorry for gestures vaguely all of this. Second, I think we have found a performance bug related to a suboptimal plan selection when evaluating predicate.

Here is a pair of TPC-H queries that exhibit this behavior. They both ask the database system to project a column in the orders table only if the predicate on the nation table is true.

SELECT o_orderpriority
FROM   orders
WHERE  (SELECT n_comment
        FROM   nation
        ORDER  BY n_comment
        LIMIT  1) IS NOT DISTINCT FROM 'random string';

SELECT o_orderpriority
FROM  orders
LEFT OUTER JOIN
                (SELECT   *
                 FROM     nation
                 ORDER BY n_comment limit 1) AS t ON TRUE
WHERE t.n_comment IS NOT DISTINCT FROM 'random string'; 

Actual Behavior The first query takes ~8.3 seconds on v20.1.3, while the second query only takes ~44 milliseconds. For the first query, the database system scans the large orders table (7500000 rows), even when the predicate on the nation table can be evaluated within a few milliseconds. (only 25 rows). Its "EXPLAIN ANALYZE" result is here. For the second query, the database system evaluates the predicate on the nation table first, which can avoid the unnecessary scan of the orders table if the predicate turns out to be false. Its "EXPLAIN ANALYZE" result is here.

Expected Behavior I would have expected the database system run these two queries with similar execution time, given that they both have the same semantics. To this end, the optimizer should generate a better execution plan for the first query, such as the plan generated for the second query. Here are the steps for reproducing our observations:

Test environment

• Ubuntu 20.04 machine "Linux panda 5.4.0-40-generic #44-Ubuntu SMP Tue Jun 23 00:01:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux"
• Cockroachdb v20.1.3
• Database: TPC-H benchmark (with scale factor 5)

Reproduce Bug

1. Install cockroachdb v20.1.3

    $ wget -qO- https://binaries.cockroachdb.com/cockroach-v20.1.3.src.tgz | tar  xvz        
    $ cd cockroach-v20.1.3
    $ make build
    $ sudo make install

• start a cockroachdb node in your preferred working directory

  $ cockroach start --insecure --store=node1 --listen-addr=localhost:26257 --http-addr=localhost:8080 --join=localhost:26257,localhost:26258,localhost:26259 --background
  $ cockroach init --insecure --host=localhost:26257

2. Set up TPC-H test benchmark (if you already have a TPC-H benchmark set up, you can skip step2; starting from step2, all commands should run in the directory ./tpch5 after downloading and extracting it)

• Download TPC-H (scale factor of 5) and extract it Download the dataset from the link: https://drive.google.com/file/d/1ZHldLW2iPfpsRh6lL-slcUoKazfai4P7/view?usp=sharing

  $ tar xzvf tpch5.tar.gz
  $ cd tpch5
  $ chmod +x setup.sh

• Create DB and TPC-H schema $ cockroach sql --insecure --host=localhost:26257
  In CockroachDB's built-in SQL client to create database:

  $ create database tpch5;
  $ exit

• Create TPC-H Schema $ cockroach sql --insecure --host=localhost:26257 -d tpch5 < dss.ddl

• Import benchmark $ ./setup.sh

  3. Test SQL query that exhibits performance issue

• Execute the queries $ cockroach sql --insecure --host=localhost:26257 -d tpch5 < query.sql

Jira issue: CRDB-4007

Epic CRDB-1491

[RaduBerinde]

Hi! Thank you for the detailed information.

This is a pretty strange query - we either return the entire table or nothing. I think the fact that the second plan runs faster is to some extent an accident - the join process exits early when it sees that one side has no rows. I guess we could add some extra checking in the scan if the filter turns out to be constant and false. This is part of a greater problem that we currently can't reoptimize parts of the query with the result from a subquery (#23264).

Is there a reason you can't check the condition on the client side instead?

You could also write it this way which is I think more clear, and it should work as expected:

SELECT
  o_orderpriority
FROM
  orders
LIMIT
  CASE
  WHEN (SELECT n_comment FROM nation ORDER BY n_comment LIMIT 1) IS NOT DISTINCT FROM 'random string'
  THEN 1000000000
  ELSE 0
  END

[xinyuliu12]

Thanks for your detailed reply! It would be great if you could comment on the challenges associated with optimizing these queries wherein there is a dependency on the sub-query.

[RaduBerinde]

We optimize the entire expression tree (which includes any subqueries) once, and then we run the subqueries, followed by the "main" query. We don't go back and re-optimize the main query with the actual results of the subquery (which in this case would either result in removing the scan operator altogether, or removing the filter). This is mainly because of architectural reasons that were carried over from previous iterations of our system. It's something we will fix at some point.

[xinyuliu12]

Thank you so much for your explanation!

[RaduBerinde]

See #53653 for another case.

[mgartner]

See https://github.com/cockroachdb/cockroach/issues/82503#issuecomment-1163755810 for another case.