search

cockroachdb / cockroachdb-cloudformation

Quickly setup dev/test CockroachDB clusters using AWS CloudFormation and Kubernetes
https://www.cockroachlabs.com/
Apache License 2.0
12 stars 4 forks source link

Switch livenessProbe back to using the /health endpoint #18

Closed a-robinson closed 6 years ago

a-robinson commented 6 years ago

Otherwise if you don't run cockroach init quickly enough all the pods will start to be repeatedly killed by the liveness checker. It's also a more accurate reflection of the intended semantics of liveness (as opposed to readiness).

Follow-up to https://github.com/cockroachdb/cockroachdb-cloudformation/pull/17

nstewart commented 6 years ago

@a-robinson OK, let me actually test this in the wild. @benesch and I tried this without ready=1 and saw weirdness when new nodes were added.

a-robinson commented 6 years ago

For both livenessProbe and readinessProbe? Or only livenessProbe?

I wouldn't be shocked if using /health for the readinessProbe could cause some weirdness, but I would be very surprised if using it for the livenessProbe caused any problems.

nstewart commented 6 years ago

LGTM!