search

cockroachdb / docs

CockroachDB user documentation
https://cockroachlabs.com/docs
Creative Commons Attribution 4.0 International
187 stars 455 forks source link

sql: enable storage parameter syntax for primary key #12942

Open cockroach-teamcity opened 2 years ago

cockroach-teamcity commented 2 years ago

Exalate commented:

https://github.com/cockroachdb/cockroach/pull/75971 --- Release note (sql change): Previously, WITH (param=value) syntax is not allowed for primary key. However, that does not align with postgresql. Also, to support WITH (bucket_count=...) syntax for hash sharded index, we need to enable it as well. This pr also adds extra validation to prevent existing storage params from being applied to primary keys. Which means, even the syntax is accepted by the parser, none of existing storage param for inverted index is allowed on primary key. We don't actually set those params on top of PKs internally, but we need to tell user which param is supprted or not. Eventually, when we add support for bucket_count param, a param white list will be maintained for PKs.

Jira Issue: DOC-2517

exalate-issue-sync[bot] commented 2 years ago

Nick Vigilante (nickvigilante) commented: I think we need to fully document all available storage parameters first before we start documenting this.