search

cockroachdb / replicator

replicator is a toolkit for ingesting logical replication feeds into a CockroachDB cluster
Apache License 2.0
60 stars 24 forks source link

Verify ALTER CHANGEFEED ADD TABLE WITH initial_scan behavior #801

Open bobvawter opened 8 months ago

bobvawter commented 8 months ago

We need a test to verify that adding a table to an existing changefeed does the right thing if the table has pre-existing data.

ryanluu12345 commented 3 weeks ago

This can probably be a test case that we add to the cdc/server/integration_test.go since we already have test cases that test changefeed integration with the CDC server, namely TestWorkload.

Sounds like we just need to be able to allow the changefeed to be created with initial_scan='yes' and then verify the data from an existing seeded table is added. My initial thought here is that we can accumulate data and write to the source before we even create the changefeed so that at least one of the sources is seeded.