cocoastorm / vue-paypal-checkout

A simple Vue.js wrapper component for paypal-checkout
MIT License
153 stars 67 forks source link

document dev="true" as sandbox #9

Closed janzheng closed 6 years ago

janzheng commented 6 years ago

Hey, I think your wrapper is great! But could you document setting :dev="true" as setting env="sandbox"? Or I would also suggest using :env="sandbox" or :env="production" in your wrapper to mimic the same language as the component.

Cheers!

cocoastorm commented 6 years ago

Hey,

Thanks for the suggestion! This definitely makes more sense. I'll publish the change soon.

janzheng commented 6 years ago

That was fast! Keep up the good work

On Mon, Feb 5, 2018 at 2:12 PM, Khoa Nguyen notifications@github.com wrote:

Hey,

Thanks for the suggestion! This definitely makes more sense. I'll publish the change soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/khoanguyen96/vue-paypal-checkout/issues/9#issuecomment-363189790, or mute the thread https://github.com/notifications/unsubscribe-auth/ADsHaAlR-eALKpkSWASSP3fwUF8OjeS7ks5tR1KQgaJpZM4R4LwQ .