search

cocogitto / cocogitto-action

A github action to ensure your current gitlog respect the conventional commit specification
22 stars 17 forks source link

[BUG] GitHub action doesn't fail even though cog check does #1

Closed mbehr1 closed 2 years ago

mbehr1 commented 2 years ago

Describe the bug Even though the commit message pushed/tested lets cog check fail the GitHub action succeeds.

To Reproduce See here: https://github.com/mbehr1/adlt/runs/4753498724?check_suite_focus=true

Expected behavior Action should fail if cog check fails.

Additional context Seems as if the "shell=bash" used is set to shell: /usr/bin/sh -e {0} so will always return 0?

oknozor commented 2 years ago

Hey @mbehr1 this is fixed already in the latest github action version: cocogitto/cocogitto-action@v2.1. Also you need to update your cog.toml file to match the latest version config (see: the config reference. You can also take a look at cocogitto's config.

I am closing this, don't hesitate to reopen if this does not work for you.

mbehr1 commented 2 years ago

@oknozor thx! Yep, that's working now :-) Btw: I changed to "uses: cocogitto/cocogitto-action@v2" and not to "uses: oknozor/cocogitto-...". Is that correct? (Now I still struggle with the --from-latest-tag not working in CI. But will investigate a little further first :-)