search

cocogitto / cocogitto-action

A github action to ensure your current gitlog respect the conventional commit specification
22 stars 17 forks source link

[BUG] `git-email` values with spaces, even when double-quoted, cause failed builds #28

Open nharward opened 1 month ago

nharward commented 1 month ago

Describe the bug Specifying a value of git-user with spaces, even wrapped with double-quotes, fails the action when run.

To Reproduce Use a value for git-user such as My User or "My User". Run the action, only the first word will be used as the git-user argument and the next word as the value for git-email.

Expected behavior The YAML string, quoted or not, as defined in the GHA workflow file should be used as the value for git-commit.

Additional context I believe the issue is in the cog step of action.yml, specifically that the action inputs are not quoted when calling cog.sh. I suspect wrapping each of those arguments in double quotes would resolve the issue.

eshepelyuk commented 1 month ago

Hello @nharward Will you be interested to try my maintained fork https://github.com/eshepelyuk/cocogitto-diya

This bug is fixed there together with other improvements.