search

cocogitto / cocogitto-action

A github action to ensure your current gitlog respect the conventional commit specification
22 stars 17 forks source link

[BUG] The action cannot parse cog.toml packages entry #9

Closed szattila98 closed 1 year ago

szattila98 commented 1 year ago

Hi!

Describe the bug I configured the action as described here. Cocogitto can verify my commits locally without problems, but when I try running the github action it says that my config is invalid, because of the [packages] entry as it is not allowed.

To Reproduce Try using the action with a monorepo cog.toml config that has a [packages] entry.

Expected behavior I expected that the action can parse the cog.toml and runs correctly, just as it does locally.

Additional context I think it is because the action uses an older version of cocogitto. The log and my action config.

Thanks in advance!

szattila98 commented 1 year ago

I tried it with 3.4, and now it says that I have a merge commit which is strange, because I clearly don't have one. https://github.com/szattila98/binge_at_home/actions/runs/5339410486/jobs/9678078800 It ran correctly with the ignore_merge_commits = true option, but still it is kinda strange. I thought that if I specify version 3 it will use the latest of the third major version, but it did not.

oknozor commented 1 year ago

can you provide your github action files ? I can't see them on the repo.

szattila98 commented 1 year ago

Sure, they are on the project-init branch, here.

szattila98 commented 1 year ago

As the new cocogitto binary came out, the new hook config cannot be parsed, please bump the version if you can. Thanks in advance.

oknozor commented 1 year ago

https://github.com/cocogitto/cocogitto-action/releases/tag/v3.5