cocur / slugify

Converts a string to a slug. Includes integrations for Symfony, Silex, Laravel, Zend Framework 2, Twig, Nette and Latte.
MIT License
2.87k stars 251 forks source link

Dependencies between rulesets? #339

Open rulatir opened 1 month ago

rulatir commented 1 month ago

Code in the DefaultRuleProvider class clearly shows that the ukrainian ruleset requires russian to also be applied - otherwise only Ukrainian-specific Cyrillic letters are transliterated, and unaccented Cyrillic letters are not. This is not the case with the bulgarian ruleset that handles the Bulgarian variant of the Cyryllic alphabet in its entirety.

I believe the basic Cyrillic transliteration should be inlined in the ukrainian ruleset, just like with bulgarian. Even if applying russian and ukrainian rulesets will have the exact same effect, treating Ukrainian as if it were a variety of Russian feels wrong in 2024.