code-423n4 2021-04-vader-findings issues

code-423n4 / 2021-04-vader-findings

1 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Unnecessary function calls in `addLiquidity`

#320 code423n4 opened 3 years ago
0
Unnecessary `else if` statement in `swapWithSynthsWithLimit`

#319 code423n4 opened 3 years ago
1
Could early return in function `borrowForMember` if `_collateral` is 0.

#318 code423n4 closed 3 years ago
1
Unrestricted `addLiquidity` could cause unintended results on front-end apps that listen to events.

#317 code423n4 opened 3 years ago
3
Users may unintendedly remove liquidity under a phishing attack.

#316 code423n4 opened 3 years ago
3
Unrestricted access to `lockUnits` allows an attacker to steal funds from any user.

#315 code423n4 closed 3 years ago
3
Allowing duplicated anchors could cause bias on anchor price.

#314 code423n4 opened 3 years ago
1
Out-of-bound index access in function `getAnchorPrice`

#313 code423n4 opened 3 years ago
1
Unused and Unnecessary code

#312 code423n4 opened 3 years ago
0
Tokens are vulnerable to double-spend allowance

#311 code423n4 closed 3 years ago
2
Functions can be declared external

#310 code423n4 closed 3 years ago
2
_addDebtToMember and _removeDebtFromMember separately tracks debt and collateral

#309 code423n4 closed 3 years ago
1
repayDelay is not used anywhere

#308 code423n4 closed 3 years ago
2
flashProof is not effective at the start

#307 code423n4 opened 3 years ago
0
Variables can be declared constant

#306 code423n4 closed 3 years ago
2
Storage variables are never used

#305 code423n4 closed 3 years ago
2
Unused ID field in structs

#304 code423n4 opened 3 years ago
1
token == arrayAnchors[i]

#303 code423n4 opened 3 years ago
1
You don't need to recalculate exclusion fee every time

#302 code423n4 opened 3 years ago
0
Function can be simplified

#301 code423n4 opened 3 years ago
0
excludedCount

#300 code423n4 opened 3 years ago
0
totalSupply + amount > maxSupply

#299 code423n4 opened 3 years ago
1
A proposal can be cancelled by anyone

#298 code423n4 closed 3 years ago
3
uint can never be negative

#297 code423n4 closed 3 years ago
2
Flip functions can be refactored

#296 code423n4 closed 3 years ago
2
GRANT type never changes

#295 code423n4 closed 3 years ago
1
Identical if-else branches

#294 code423n4 closed 3 years ago
1
Fee on transfer conditions

#293 code423n4 opened 3 years ago
0
Some storage optimizations

#292 code423n4 opened 3 years ago
1
Cache duplicate calls or storage access

#291 code423n4 opened 3 years ago
0
Unused variables

#290 code423n4 closed 3 years ago
2
Extract mappings to a common struct

#289 code423n4 opened 3 years ago
3
variable == false -> !variable

#288 code423n4 opened 3 years ago
1
Extra useless steps to calculate pooledVADER and pooledUSDV

#287 code423n4 opened 3 years ago
1
Use immutable for constant variables

#286 code423n4 opened 3 years ago
1
[INFO] Code style suggestions

#285 code423n4 opened 3 years ago
0
convert collects funds even when minting is disabled

#284 code423n4 closed 3 years ago
2
ERC20 specification declares decimals as uint8 type

#283 code423n4 opened 3 years ago
1
It is possible to vote, finalise and execute the same proposal several times

#282 code423n4 closed 3 years ago
5
Weird calculation of Vader/USD price

#281 code423n4 closed 3 years ago
2
_finalise inside finaliseProposal can never be triggered

#280 code423n4 closed 3 years ago
2
_recordBurn calls _updateEmission afterwards

#279 code423n4 closed 3 years ago
1
Anyone can set mapTokenMember_Units

#278 code423n4 closed 3 years ago
3
calculations of upgradedAmount is not overflow protected

#277 code423n4 opened 3 years ago
0
Function can be simplified

#276 code423n4 closed 3 years ago
2
Handle transfers of different ERC20 tokens

#275 code423n4 closed 3 years ago
1
curatePool emits Curated event no matter what

#274 code423n4 opened 3 years ago
0
You can vote for proposal still not existent

#273 code423n4 opened 3 years ago
0
Swap fee not applied

#272 code423n4 opened 3 years ago
0
listAnchor sets _isCurated to true but forgets other parts of curation

#271 code423n4 opened 3 years ago
0