Missing parameter validation

[code423n4]

Handle

cmichel

Vulnerability details

Vulnerability Details

Some parameters of functions are not checked for invalid values:

• BaseVaultAdaptor.constructor: The addresses should be checked for non-zero values
• LifeGuard3Pool.constructor: The addresses should be checked for non-zero values
• Buoy3Pool.constructor: The addresses should be checked for non-zero values
• PnL.constructor: The addresses should be checked for non-zero values
• Controllable.setController: Does not check that newController != controller

Impact

A wrong user input or wallets defaulting to the zero addresses for a missing input can lead to the contract needing to redeploy or wasted gas.

Recommended Mitigation Steps

Validate the parameters.

[kitty-the-kat]

Low risk/Non critical - Deployment script handles these cases, but good practice to have 0x checks to stop wasting gas and having to redeploy.