code-423n4 2021-07-wildcredit-findings issues

code-423n4 / 2021-07-wildcredit-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Use of deprecated Chainlink function `latestAnswer`

#143 code423n4 closed 3 years ago
1
The interest rate is calculated based on assumptions on the block time

#142 code423n4 opened 3 years ago
2
Deflationary and fee-on-transfer tokens are not correctly accounted

#141 code423n4 closed 3 years ago
2
Unimplemented methods in several interfaces

#140 code423n4 opened 3 years ago
2
Unnecessary comparison with `MIN_RATE` in `InterestRateModel`

#139 code423n4 closed 3 years ago
2
Add a proper revert message in `transferFrom` of `LPTokenMaster`

#138 code423n4 opened 3 years ago
2
Return values of `rewardToken.transfer` are unchecked

#137 code423n4 closed 3 years ago
1
Incorrect parameter used in the `addPool` event of `RewardDistribution`

#136 code423n4 closed 3 years ago
1
ERC20 tokens may not implement the `decimals` method

#135 code423n4 closed 3 years ago
2
Use of unlocked pragmas

#134 code423n4 closed 3 years ago
1
Math.max can be used

#133 code423n4 opened 3 years ago
0
Boolean to constant comparison

#132 code423n4 opened 3 years ago
0
typo in revert

#131 code423n4 opened 3 years ago
0
typo: totalAccountBorrrow

#130 code423n4 opened 3 years ago
0
Variables are already of type address

#129 code423n4 closed 3 years ago
1
Unused imported interface in LendingPair

#128 code423n4 opened 3 years ago
0
Recommended

#127 code423n4 opened 3 years ago
1
## Recommended Mitigation Steps

#126 code423n4 closed 3 years ago
2
repayAll() and repayAllETH() vulnerable to frontrunning

#125 code423n4 opened 3 years ago
0
`LendingPair.pendingSupplyInterest` is not accurate

#124 code423n4 opened 3 years ago
0
`LendingPair.liquidateAccount` fails if tokens are lent out

#123 code423n4 opened 3 years ago
2
`LendingPair.liquidateAccount` does not accrue and update cumulativeInterestRate

#122 code423n4 opened 3 years ago
2
`LendingPair._safeTransfer` does not work with all ERC20 tokens

#121 code423n4 closed 3 years ago
1
TransferHelper does not work with all ERC20 tokens

#120 code423n4 closed 3 years ago
1
Simple interest formula is used

#119 code423n4 opened 3 years ago
0
Uniswap oracle assumes PairToken <> WETH liquidity

#118 code423n4 opened 3 years ago
1
ChainLink price data could be stale

#117 code423n4 closed 3 years ago
1
Reward computation is wrong

#116 code423n4 opened 3 years ago
2
Total LP supply & total debt accrual is wrong

#115 code423n4 opened 3 years ago
2
`initialize` functions can be frontrun

#114 code423n4 closed 3 years ago
2
LPTokenMaster does not implement `IERC20`

#113 code423n4 opened 3 years ago
2
Interest model is non-continuous

#112 code423n4 opened 3 years ago
2
Missing parameter validation

#111 code423n4 closed 3 years ago
2
Variables that can be converted into immutables

#110 code423n4 opened 3 years ago
0
when setting new value for feeRecepient/totalRewardPerBlock ensure that new value is different from old one

#109 code423n4 opened 3 years ago
0
Lack of zero address validation

#108 code423n4 opened 3 years ago
1
Lack of Input validation in selfBurn() & burn()

#107 code423n4 closed 3 years ago
2
Use safetransfer/safetransferfrom consistently instead of transfer/transferfrom

#106 code423n4 closed 3 years ago
2
Incorrect position of require() in TransferHelper.sol

#105 code423n4 closed 3 years ago
1
Uneccessary condition in RewardDistribution.sol

#104 code423n4 closed 3 years ago
2
Packing of variable in controller.sol

#103 code423n4 opened 3 years ago
0
Migrate Rewards Without Distribution

#102 code423n4 opened 3 years ago
1
Insuffiecient input validation in initialize() in LendingPair.sol

#101 code423n4 closed 3 years ago
2
Unused return value from transfer()

#100 code423n4 closed 3 years ago
1
Use of Floating Pragma

#99 code423n4 opened 3 years ago
1
Lack of access modifier in initialize() in LPTokenMaster.sol

#98 code423n4 closed 3 years ago
2
Owner can burn other users token shares

#97 code423n4 closed 3 years ago
2
Erc20 Race condition for allowance

#96 code423n4 opened 3 years ago
2
Global borrowing/deposit enabled checks not granular enough

#95 code423n4 closed 3 years ago
2
The safe versions of transfer/transferFrom are not implemented as expected

#94 code423n4 closed 3 years ago
1