Recommend adding a nonReentrant modifier to external functions

[code423n4]

Handle

tensors

Vulnerability details

Impact

The external functions given to the user have no checks for reentrancy.

An ounce of prevention is worth a pound of cure: when possible (i.e. most external functions) could use a nonReentrant modifier.

I haven't been able to find any reentrancies in my search, but for complicated code like this it is recommended to add checks anyway. It reduces the attack surface by an enormous amount.

[jeffywu]

A best practice recommendation should be 0 Non Critical in my opinion. There is no explicit attack vector mentioned here.

[ghoul-sol]

This is a best practice recommendation, so non-critical