code-423n4 2021-08-notional-findings issues

code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

NotionalV1ToNotionalV2 should reject ETH transfers from others than WETH

#48 code423n4 opened 3 years ago
0
Check if address is a contract

#47 code423n4 opened 3 years ago
0
notionalCallback returns no value

#46 code423n4 opened 3 years ago
0
notionalCallback can be tricked by anyone

#45 code423n4 opened 3 years ago
1
Address.isContract with no check of returned value

#44 code423n4 opened 3 years ago
0
lack of input validation of arrays

#43 code423n4 opened 3 years ago
0
initialize() function of router.sol can be reinitialize

#42 code423n4 opened 3 years ago
2
unchecked return value from isContract()

#41 code423n4 opened 3 years ago
2
use of floating pragma

#40 code423n4 opened 3 years ago
1
Insufficient validation of rate value

#39 code423n4 opened 3 years ago
1
Use of transfer() instead of call() to send eth

#38 code423n4 opened 3 years ago
2
Erc20 Race condition

#37 code423n4 opened 3 years ago
2
Incorrect event parameters in transferFrom function

#36 code423n4 opened 3 years ago
2
proposal get defeated even if forVotes == againstVotes in GovernorAlpha.sol

#35 code423n4 opened 3 years ago
2
SHOULD CHECK RETURN DATA FROM CHAINLINK AGGREGATORS

#34 code423n4 opened 3 years ago
1
proRataYears is sometimes 0.

#33 code423n4 opened 3 years ago
2
Settle Portfolio state could be griefed.

#32 code423n4 opened 3 years ago
2
Consider using a solidity version >= 0.8.0

#31 code423n4 opened 3 years ago
2
Some TradingActions do not have frontrunning protections

#30 code423n4 opened 3 years ago
3
No checks on target variable

#29 code423n4 opened 3 years ago
0
batchBalanceAction could make multiple deposits with the same msg.value?

#28 code423n4 opened 3 years ago
1
Recommend adding a nonReentrant modifier to external functions

#27 code423n4 opened 3 years ago
2
Add buffer, haircut and liquidation discount checks.

#26 code423n4 opened 3 years ago
2
ERC1155 has reentrancy possibilities.

#25 code423n4 opened 3 years ago
2
Can't call external functions internally

#24 code423n4 opened 3 years ago
2
Gas savings: variables can all be a multiple of each other

#23 code423n4 opened 3 years ago
2
Idiosyncratic fCash valuation is incorrect

#22 code423n4 opened 3 years ago
2
Can a small order change the lastImpliedRate significantly?

#21 code423n4 opened 3 years ago
2
Attackers can force liquidations by borrowing large amounts of an asset.

#20 code423n4 opened 3 years ago
2
Time window must be chosen carefully

#19 code423n4 opened 3 years ago
2
.latestRoundData() does not update the oracle - ExchangeRate.sol

#18 code423n4 opened 3 years ago
1
Uniswap oracles in valuation/ExchangeRate.sol are lagging indicators.

#17 code423n4 closed 3 years ago
3
Consider deploying on a sidechain or an L2?

#16 code423n4 opened 3 years ago
2
TokenHandler.sol, L174 - .transfer is bad practice

#15 code423n4 opened 3 years ago
1
Possible reentrancy in balanceOf, decimals, mint

#14 code423n4 opened 3 years ago
2
Gas optimization: Can put require and variable declaration inside the if statement.

#13 code423n4 opened 3 years ago
1
Flipped boolean or confusing notation on TokenHandler.sol

#12 code423n4 opened 3 years ago
2
Can initiate the same token multiple times with different currency IDs

#11 code423n4 opened 3 years ago
2
Reentrancy Bug in `TimelockController.sol`

#10 code423n4 opened 3 years ago
1
Gas optimization on _INT256_MIN

#9 code423n4 opened 3 years ago
1
unsafe cast from int to uint can lead to incentive abuse

#8 code423n4 opened 3 years ago
2
DOS by Frontrunning NoteERC20 `initialize()` Function

#7 code423n4 opened 3 years ago
0
_transfer what happens if sender==recipient

#6 code423n4 opened 3 years ago
2
Use pragma abicoder v2

#5 code423n4 opened 3 years ago
2
Double check for "birthday" collision

#4 code423n4 opened 3 years ago
0
executing instruction outside code can lead to failing transfer

#3 code423n4 opened 3 years ago
4
Lack of address Validation

#2 code423n4 opened 3 years ago
2
Self transfer can lead to unlimited mint

#1 code423n4 opened 3 years ago
1