code-423n4 2021-10-tracer-findings issues

code-423n4 / 2021-10-tracer-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Summarize your findings for the bug or vulnerability

#42 code423n4 closed 3 years ago
1
Summarize your findings for the bug or vulnerability.

#41 code423n4 closed 3 years ago
1
staticcall may return true for an invalid _yieldSource

#40 code423n4 closed 3 years ago
1
calculateNextBeaconPeriodStartTime casts timestamp to uint64

#39 code423n4 closed 3 years ago
1
Style issues

#38 code423n4 closed 3 years ago
1
token out of range check can be simplified

#37 code423n4 opened 3 years ago
1
Useless multiplication by 1

#36 code423n4 opened 3 years ago
1
Checking non-zero transfer value can avoid an external call

#35 code423n4 closed 3 years ago
3
Unchecked operations

#34 code423n4 closed 3 years ago
2
Unused imports

#33 code423n4 opened 3 years ago
1
Immutable state variables

#32 code423n4 opened 3 years ago
1
Unused state variables

#31 code423n4 opened 3 years ago
1
BLOCK_TIME of Arbitrum is less than 13 seconds

#30 code423n4 opened 3 years ago
2
Inclusive check of frontRunning > updateInterval

#29 code423n4 closed 3 years ago
1
Cache array length in for loops can save gas

#28 code423n4 closed 3 years ago
3
Adding unchecked directive can save gas

#27 code423n4 opened 3 years ago
2
`PoolKeeper.sol#performUpkeepSinglePool()` Wrong implementation allows attacker to interfere the upkeep of pools

#26 code423n4 opened 3 years ago
2
`PoolCommitter.sol#commit()` Calculation of `amountOut` is wrong

#25 code423n4 closed 3 years ago
3
`PoolCommitter.sol#._uncommit()` Tokens are not returned to the commit owner

#24 code423n4 closed 3 years ago
1
Wrong keeper reward computation

#23 code423n4 opened 3 years ago
1
Gas: Inefficient modulo computation

#22 code423n4 opened 3 years ago
2
Validate max fee

#21 code423n4 opened 3 years ago
2
No ERC20 `safeApprove` versions called

#20 code423n4 opened 3 years ago
5
`uncommit` sends tokens to the wrong user

#19 code423n4 opened 3 years ago
11
`commit` burn yields wrong `amountOut` computation

#18 code423n4 closed 3 years ago
2
Deposits don't work with fee-on transfer tokens

#17 code423n4 opened 3 years ago
2
Gas: `transferGovernance` can save an sload

#16 code423n4 opened 3 years ago
1
Gas: Use `isToken0` boolean instead of `uint256 token`

#15 code423n4 closed 3 years ago
1
Unsafe `int256` casts in `executePriceChange`

#14 code423n4 opened 3 years ago
2
Revert in `poolUpkeep`

#13 code423n4 opened 3 years ago
3
Gas: shadow pools are only required for burn types

#12 code423n4 opened 3 years ago
1
Missing parameter validation

#11 code423n4 opened 3 years ago
2
LeveragedPool has require statements which are also checked in library

#10 code423n4 opened 3 years ago
1
PoolKeeper _gasPrice description says in ETH, but is calculated in wei

#9 code423n4 closed 3 years ago
1
PoolFactory constructor doesn't check whether _feeReceiver is zero address

#8 code423n4 closed 3 years ago
2
Contradiction in comment/require statement

#7 code423n4 opened 3 years ago
2
Unused Named Returns Can Be Removed

#6 code423n4 opened 3 years ago
1
No constant for maximum tip (PoolKeeper.sol)

#5 code423n4 closed 3 years ago
1
Unused modifer "onlyFeeReceiver" in LeveragedPool.sol

#4 code423n4 closed 3 years ago
1
Minimize Storage Slots (LeveragedPool.sol)

#3 code423n4 opened 3 years ago
1
Unused local variable in _latestRoundData (ChainlinkOracleWrapper.sol)

#2 code423n4 closed 3 years ago
1
Array's length value is used directly in a for loop

#1 code423n4 closed 3 years ago
3