code-423n4 / 2021-10-tracer-findings

0 stars 0 forks source link

Useless multiplication by 1 #36

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

Uneccesarry multiplication by 1 here: require(initialization._fee < 1 * PoolSwapLibrary.WAD_PRECISION, "Fee >= 100%");

Recommended Mitigation Steps

require(initialization._fee < PoolSwapLibrary.WAD_PRECISION, "Fee >= 100%");

GalloDaSballo commented 3 years ago

Agree with the finding 1 * X is X