code-423n4 / 2021-10-tracer-findings

0 stars 0 forks source link

Unused modifer "onlyFeeReceiver" in LeveragedPool.sol #4

Closed code423n4 closed 3 years ago

code423n4 commented 3 years ago

Handle

ye0lde

Vulnerability details

Impact

Code clarity. I didn't see anywhere it should be used but that would increase the impact.

Proof of Concept

Unused modifer "onlyFeeReceiver" in LeveragedPool.sol: https://github.com/tracer-protocol/perpetual-pools-contracts/blob/646360b0549962352fe0c3f5b214ff8b5f73ba51/contracts/implementation/LeveragedPool.sol#L403-L406

I didn't see anywhere it should be used but that is something to consider.

Tools Used

Visual Studio Code

Recommended Mitigation Steps

Remove or use the unused modifier.

GalloDaSballo commented 3 years ago

Deleting unused modifiers will reduce bytecode size, and unused code is a code-smell, agree with the finding