code-423n4 / 2021-10-union-findings

0 stars 0 forks source link

More efficient loops #100

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

Tons of for loops with i++ instead ++i. And unchecked {++i} is better. This is relevant to every for loop in the code. We suggest to change to unchecked{++i} instead of the current code. You will never reach 2^256...

GalloDaSballo commented 3 years ago

Agree with the finding although I can only imagine the readability of a bunch of unchecked in a for loop