code-423n4 / 2021-10-union-findings

0 stars 0 forks source link

UserManager: addMember() contains redundant require check #38

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

itsmeSTYJ

Vulnerability details

Impact

Gas optimisation. The require check in addMember() is not required because 1) only the admin can call this function and 2) even if it were to be called again, it is overriding the storage with the same value so it doesn't change anything.