code-423n4 / 2021-10-union-findings

0 stars 0 forks source link

UToken.sol _redeemFresh could be set private instead internal #95

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pants

Vulnerability details

This is one of many examples of the appearance of private instead of internal. Since we manually code reviewing and writing issues we don't list all the appearances. Calling a private function is more gas efficient than calling internal.

Here we refer to UToken.sol._redeemFresh function that is used only in UToken.sol file.

GalloDaSballo commented 3 years ago

Agree with the specific example given as UToken is not inherited from any contract