code-423n4 2021-10-union-findings issues

code-423n4 / 2021-10-union-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Cache array length in for loops can save gas

#60 code423n4 opened 3 years ago
1
Cache and read storage variables from the stack can save gas

#59 code423n4 closed 3 years ago
2
Adding unchecked directive can save gas

#58 code423n4 opened 3 years ago
1
Cache and read storage variables from the stack can save gas

#57 code423n4 opened 3 years ago
1
Avoid unnecessary code execution can save some gas in edge cases

#56 code423n4 opened 3 years ago
1
Unused imports

#55 code423n4 opened 3 years ago
0
Code Style: public/external function names should not be prefixed with `__`

#54 code423n4 closed 3 years ago
1
Exit loop can save some gas

#53 code423n4 closed 3 years ago
1
Code Style: consistency

#52 code423n4 opened 3 years ago
1
Use short circuiting can save gas

#51 code423n4 opened 3 years ago
1
UserManager: updateLockedData() doesn't check that the amount is actually locked.

#50 code423n4 closed 3 years ago
1
UserManager: updateLockedData() locks more amount than required.

#49 code423n4 closed 3 years ago
5
UserManager: debtWriteOff() function doesn't update state in comptroller

#48 code423n4 closed 3 years ago
1
UserManager: totalStaked ≥ totalFrozen should be checked before and after totalFrozen is updated

#47 code423n4 opened 3 years ago
1
UserManager: _getFrozenCoinAge is not used

#46 code423n4 opened 3 years ago
1
AssetManager: getLoanableAmount() can be made more readable

#45 code423n4 opened 3 years ago
1
UserManager: debtWriteOff() doesn't need if borrower has sufficient assets frozen before subtracting

#44 code423n4 opened 3 years ago
2
UserManager: _updateTotalFrozen can be optimized further

#43 code423n4 opened 3 years ago
2
UserManager: allowance check in stake() function is not required

#42 code423n4 closed 3 years ago
1
UserManager: registerMember() can be optimized further

#41 code423n4 opened 3 years ago
1
UserManager: cancelVouch() should break from loop when address is found.

#40 code423n4 opened 3 years ago
1
UserManager: use mapping to avoid iteration

#39 code423n4 opened 3 years ago
1
UserManager: addMember() contains redundant require check

#38 code423n4 opened 3 years ago
0
UserManager: getCreditLimit() can be optimized further

#37 code423n4 opened 3 years ago
1
UserManager: getTotalLockedStake() redundant assignment

#36 code423n4 opened 3 years ago
1
UserManager: getBorrowerAsset() can be optimized further

#35 code423n4 closed 3 years ago
1
CreditLimitByMedian: getLockedAmount() can be optimized further.

#34 code423n4 opened 3 years ago
1
UToken: revert on over/underflow checks in addReserve() and removeReserve() are unnecessary

#33 code423n4 opened 3 years ago
1
UToken: Allowance check in mint() can be removed

#32 code423n4 closed 3 years ago
1
UToken: _repayBorrowFresh() function can be optimized further

#31 code423n4 opened 3 years ago
1
AssetManager: rebalance() function can optimized further.

#30 code423n4 closed 3 years ago
1
AssetManager: Deposit() function has redundant continue statement.

#29 code423n4 opened 3 years ago
1
debtWriteOff updates totalFrozen immaturely, thereby losing staker rewards

#28 code423n4 opened 3 years ago
1
For Loops Need Break Statements (UserManager.sol)

#27 code423n4 opened 3 years ago
1
Function getFrozenCoinAge Can Be Made More Efficient (UserManager.sol)

#26 code423n4 opened 3 years ago
2
UserManager stake function sets assetManager allowance to 0 right before setting allowance to amount

#25 code423n4 closed 3 years ago
1
stake function in UserManager checks for allowance, which is also done in ERC20 transferFrom

#24 code423n4 opened 3 years ago
1
Function checkIsOverDue Can Be Made More Efficient (UToken.sol)

#23 code423n4 opened 3 years ago
1
Functions TotalSupplyView/TotalSupply Can Be Made More Efficient (AssetManager.sol)

#22 code423n4 opened 3 years ago
1
Change in interest rate can disable repay of loan

#21 code423n4 opened 3 years ago
1
Inconsistent use of `UToken::getLastRepay()`

#20 code423n4 opened 3 years ago
1
Inconsistent use of `UToken::getBorrowed()`

#19 code423n4 opened 3 years ago
1
Unneeded Named Returns (UToken.sol)

#18 code423n4 opened 3 years ago
1
Long Revert Strings

#17 code423n4 opened 3 years ago
1
Tautologies in require statements

#16 code423n4 opened 3 years ago
1
Lock pragma compiler version

#15 code423n4 closed 3 years ago
1
Missing events for owner only functions that change critical parameters

#14 code423n4 opened 3 years ago
1
Improper Upper Bound Definition on the New Member Fee

#13 code423n4 opened 3 years ago
2
Gas wastage while finding staker and borrower

#12 code423n4 closed 3 years ago
1
rebalance function will fail due to invalid condition

#11 code423n4 closed 3 years ago
1

Previous Next