search

code-423n4 / 2021-11-overlay-findings

1 stars 0 forks source link

Discrepancies between the interface and implementation #119

Open code423n4 opened 3 years ago

code423n4 commented 3 years ago

Handle

pauliax

Vulnerability details

Impact

IOverlayV1Market declares a function adjustParams but OverlayV1Market does not have such a function. There may be more examples where interface and contract differ.

Recommended Mitigation Steps

Consider explicitly inheriting an interface to enforce compile-time check:

 contract OverlayV1Market is IOverlayV1Market
mesozoic-technology commented 2 years ago

We hadn't reached the point where we were going to make sure a number of things about the contract, including absolute adherence between the interfaces and the contracts. So we acknowledge.