issues
search
code-423n4
/
2021-11-streaming-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Not tracking tokens claimed minus deposit tokens (Locke.sol)
#272
code423n4
closed
2 years ago
2
balance(dust) rewardsTokens may be unclaimable after endRewardLock
#271
code423n4
opened
2 years ago
1
global unstreamed value is not updated after stream depositor withdraws an amount
#270
code423n4
closed
2 years ago
1
In-consistency in feePercent check in StreamFactory.updateFeeParams() and Stream.constructor()
#269
code423n4
closed
2 years ago
1
reset depositTokenAmount in creatorClaimSoldTokens
#268
code423n4
closed
2 years ago
1
Declaring unnecessary immutable variables as constant can save gas
#267
code423n4
closed
2 years ago
1
Changing function visibility from public to external can save gas
#266
code423n4
closed
2 years ago
1
Remove unnecessary function can make the code simpler and save some gas
#265
code423n4
opened
2 years ago
0
`++i` is more efficient than `i++`
#264
code423n4
closed
2 years ago
1
`++currStreamId` is more gas efficient than `currStreamId += 1`
#263
code423n4
opened
2 years ago
0
Avoid unnecessary external calls can save gas
#262
code423n4
opened
2 years ago
1
`* 10 / 10000` can be simpler and save some gas
#261
code423n4
closed
2 years ago
1
Code Style: public functions not used by current contract should be external
#260
code423n4
opened
2 years ago
1
`Stream#claimReward()` storage writes and reads of `ts.rewards` can be combined into one
#259
code423n4
opened
2 years ago
0
Improper implementation of `arbitraryCall()` allows protocol gov to steal funds from users' wallets
#258
code423n4
opened
2 years ago
1
merkleAccess is unnecessary
#257
code423n4
closed
2 years ago
1
Avoid unnecessary `updateStream()` can save gas
#256
code423n4
closed
2 years ago
1
Gas Optimization On The 2^256-1
#255
code423n4
opened
2 years ago
0
Use specific solidity version
#254
code423n4
closed
2 years ago
1
Inconsistent protocol fee limit check
#253
code423n4
closed
2 years ago
1
Incompatibility With Rebasing/Deflationary/Inflationary tokens
#252
code423n4
opened
2 years ago
0
Public variable `unstreamed` can be smaller than ∑ts.tokens due to `unstreamed` not being updated in `withdraw()`
#251
code423n4
closed
2 years ago
1
Redundant code
#250
code423n4
opened
2 years ago
0
Inconsistent check of token balance
#249
code423n4
opened
2 years ago
0
`10**6` can be changed to `1e6` and save some gas
#248
code423n4
opened
2 years ago
0
Gas Optimization on the Public Functions
#247
code423n4
closed
2 years ago
1
Incorrect Validation of feePercent
#246
code423n4
opened
2 years ago
1
Avoid unnecessary storage reads can save gas
#245
code423n4
opened
2 years ago
0
Adding unchecked directive can save gas
#244
code423n4
closed
2 years ago
1
Insufficient input validation
#243
code423n4
opened
2 years ago
0
ArbitraryCall() allows attackers to steal ERC20 tokens from users wallets
#242
code423n4
closed
2 years ago
1
Wrong calculation of excess depositToken allows stream creator to retrieve `depositTokenFlashloanFeeAmount`, which may cause fund loss to users
#241
code423n4
opened
2 years ago
1
Emergency Governed is not actually used and can be removed
#240
code423n4
closed
2 years ago
1
`LockeERC20.sol#toString()` Implementation can be simpler and save some gas
#239
code423n4
opened
2 years ago
0
Adding unchecked directive can save gas
#238
code423n4
opened
2 years ago
0
`ts.tokens` can potentially be reduced more than expected
#237
code423n4
closed
2 years ago
1
Constructors should not have visibility
#236
code423n4
opened
2 years ago
0
Slot packing increases runtime gas consumption due to masking
#235
code423n4
opened
2 years ago
0
Implementations should inherit their interface
#234
code423n4
opened
2 years ago
0
Remove unnecessary variables can make the code simpler and save some gas
#233
code423n4
opened
2 years ago
0
Cache and read storage variables from the stack can save gas
#232
code423n4
opened
2 years ago
0
Use immutable variables can save gas
#231
code423n4
opened
2 years ago
0
Race condition on ERC20 approval
#230
code423n4
closed
2 years ago
1
governor can steal funds of user from all created streams using `arbitraryCall`
#229
code423n4
closed
2 years ago
1
DOS while dealing with erc20 when value(i.e amount*decimals) is high but less than type(uint112).max
#228
code423n4
opened
2 years ago
1
Unused modifier parameter
#227
code423n4
closed
2 years ago
1
Emergency gov is never used
#226
code423n4
opened
2 years ago
0
Incorrect rewards are given to users
#225
code423n4
closed
2 years ago
2
unstreamed variable is not updated in withdraw function
#224
code423n4
closed
2 years ago
1
check for deposit token and reward token are not same
#223
code423n4
closed
2 years ago
1
Next