code-423n4 / 2021-11-streaming-findings

0 stars 0 forks source link

Use safe math for solidity version <8 #16

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Handle

robee

Vulnerability details

You should use safe math for solidity version <8 since there is no default over/under flow check it suchversions of solidity. The contract demo.sol doesn't use safe math and is of solidity version < 8 The contract test.sol doesn't use safe math and is of solidity version < 8 The contract Auth.sol doesn't use safe math and is of solidity version < 8 The contract RolesAuthority.sol doesn't use safe math and is of solidity version < 8 The contract TrustAuthority.sol doesn't use safe math and is of solidity version < 8 The contract Trust.sol doesn't use safe math and is of solidity version < 8 The contract DSInvariantTest.sol doesn't use safe math and is of solidity version < 8 The contract DSTestPlus.sol doesn't use safe math and is of solidity version < 8 The contract Hevm.sol doesn't use safe math and is of solidity version < 8 The contract MockAuthChild.sol doesn't use safe math and is of solidity version < 8 The contract MockTrustChild.sol doesn't use safe math and is of solidity version < 8 The contract GenericUser.sol doesn't use safe math and is of solidity version < 8 The contract Bytes32AddressLib.sol doesn't use safe math and is of solidity version < 8 The contract CREATE3.sol doesn't use safe math and is of solidity version < 8 The contract ReentrancyGuard.sol doesn't use safe math and is of solidity version < 8 The contract SafeCastLib.sol doesn't use safe math and is of solidity version < 8 The contract SSTORE2.sol doesn't use safe math and is of solidity version < 8

brockelmore commented 2 years ago

All referenced contracts are test/library contracts and not in the 3 contracts in scope as defined in the readme.

0xean commented 2 years ago

closing as invalid.