issues
search
code-423n4
/
2021-12-perennial-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
`withdrawTo` Does Not Sync Before Checking A Position's Margin Requirements
#74
code423n4
opened
2 years ago
2
DOS by Frontrunning The `initialize` Function
#73
code423n4
closed
2 years ago
3
On updating the Incentive fee greater than UFixedLib18.ONE, new Programs can not be created
#72
code423n4
opened
2 years ago
1
Initialization functions can be front-run
#71
code423n4
opened
2 years ago
4
`Collateral.sol#maintananceInvariant` can be combined with `collateralnvarant` to save gas
#70
code423n4
opened
2 years ago
2
At settleInternal, should not make calculations when not needed
#69
code423n4
closed
2 years ago
8
At settleAccountInternal, don't make calculations for pre when it does not exist
#68
code423n4
closed
2 years ago
2
At settleInternal, check whether the position can be changable to pre more efficiently
#67
code423n4
closed
2 years ago
2
At settleAccountInternal, check whether the position can be changeable to pre more efficiently
#66
code423n4
opened
2 years ago
2
At `Product.sol#closeAll`, cache `_position[account]`
#65
code423n4
opened
2 years ago
1
Libraries add extra gas cost
#64
code423n4
closed
2 years ago
2
No checks if given product is created by the factory
#63
code423n4
opened
2 years ago
2
It is possible to liquidate not existing account
#62
code423n4
closed
2 years ago
4
Loops can be implemented more efficiently
#61
code423n4
closed
2 years ago
2
For uint `> 0` can be replaced with ` != 0` for gas optimization
#60
code423n4
closed
2 years ago
2
Gas Optimization: Cache length() for iteration
#59
code423n4
closed
2 years ago
2
Gas Optimization: Struct layout
#58
code423n4
closed
2 years ago
1
Adding unchecked directive can save gas
#57
code423n4
opened
2 years ago
1
Gas: unnecessary `add`
#56
code423n4
closed
2 years ago
2
Incentivizer rewards are unclear and can be more than allotted?
#55
code423n4
closed
2 years ago
2
Fixed18 conversions don't work for all values
#54
code423n4
opened
2 years ago
1
ChainLink price data could be stale
#53
code423n4
closed
2 years ago
2
`NotControllerOwnerError` error not used
#52
code423n4
opened
2 years ago
2
`initialize` functions can be frontrun
#51
code423n4
closed
2 years ago
2
Missing fee parameter validation
#50
code423n4
opened
2 years ago
1
Improper implementation of `Fixed18.sol#abs()`
#49
code423n4
closed
2 years ago
2
Multiple initialization of Incentivizer contract
#48
code423n4
closed
2 years ago
2
Cache array length outside of loop
#47
code423n4
closed
2 years ago
2
Two Steps Verification before Transferring Ownership
#46
code423n4
closed
2 years ago
2
Improper Upper Bound Definition on the Fee
#45
code423n4
closed
2 years ago
2
SHOULD CHECK RETURN DATA FROM CHAINLINK AGGREGATORS
#44
code423n4
closed
2 years ago
2
claimFee loop does not check for zero transfer amount (Incentivizer.sol)
#43
code423n4
opened
2 years ago
1
Constant variable can be immutable (UFactoryProvider.sol)
#42
code423n4
closed
2 years ago
4
Removing redundant code can save gas (Collateral, Factory, Incentivizer, ChainlinkOracle)
#41
code423n4
opened
2 years ago
1
Cache storage variables in the stack can save gas
#40
code423n4
opened
2 years ago
1
Remove unnecessary variables can make the code simpler and save some gas
#39
code423n4
opened
2 years ago
1
Inline unnecessary function can make the code simpler and save some gas
#38
code423n4
opened
2 years ago
1
Best Practice: public functions not used by current contract should be external
#37
code423n4
opened
2 years ago
2
`Incentivizer.sol` Tokens with fee on transfer are not supported
#36
code423n4
opened
2 years ago
7
`Factory.sol#updateController()` Lack of input validation
#35
code423n4
opened
2 years ago
1
Unnecessary checked arithmetic in for loops
#34
code423n4
opened
2 years ago
2
Cache storage read and call results in the stack can save gas
#33
code423n4
opened
2 years ago
1
Reuse operation results can save gas
#32
code423n4
opened
2 years ago
1
Cache array length in for loops can save gas
#31
code423n4
opened
2 years ago
1
Avoid unnecessary `SafeCast.toInt256()` can save gas
#30
code423n4
opened
2 years ago
1
Use immutable variables can save gas
#29
code423n4
opened
2 years ago
1
`++i` is more efficient than `i++`
#28
code423n4
closed
2 years ago
2
Adding a new method `provider.currentPrice()` can save gas
#27
code423n4
opened
2 years ago
1
Avoid unnecessary external calls can save gas
#26
code423n4
opened
2 years ago
0
`initializer` functions can be front run
#25
code423n4
closed
2 years ago
2
Next