code-423n4 2022-03-joyn-findings issues

code-423n4 / 2022-03-joyn-findings

4 stars 1 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Agreements & Disclosures

#155 CloudEllie opened 2 years ago
0
Upgraded Q -> H from 110 [1655009286368]

#154 code423n4 closed 2 years ago
0
Upgraded Q -> M from 96 [1655008755771]

#153 code423n4 closed 2 years ago
0
Upgraded Q -> M from 96 [1655008585673]

#152 code423n4 closed 2 years ago
0
Upgraded Q -> H from 63 [1655008454311]

#151 code423n4 closed 2 years ago
0
Upgraded Q -> H from 63 [1655008277948]

#150 code423n4 closed 2 years ago
0
Upgraded Q -> H from 25 [1655007954017]

#149 code423n4 closed 2 years ago
0
Upgraded Q -> H from 45 [1655007594160]

#148 code423n4 closed 2 years ago
0
platformFee should be upper bounded to avoid DoS and excessive fees

#147 deluca-mike closed 2 years ago
2
Gas Optimizations

#146 deluca-mike closed 2 years ago
1
Front-runnable Initializers

#145 deluca-mike closed 2 years ago
2
Incompatibility With Rebasing/Deflationary/Inflationary tokens

#144 deluca-mike closed 2 years ago
2
CoreCollection can be re-initialized by owner

#143 deluca-mike closed 2 years ago
1
Increment window and transfer funds

#142 deluca-mike closed 2 years ago
1
transfer or transferFrom without checking the boolean result

#141 deluca-mike closed 2 years ago
2
use safe erc20 functions

#140 deluca-mike closed 2 years ago
2
Unsafe ERC20 transfer Operations

#139 deluca-mike closed 2 years ago
2
Add a max boundary for the platform fee

#138 deluca-mike closed 2 years ago
2
Don't ignore ERC20 transfer return values

#137 deluca-mike closed 2 years ago
2
onlyUnInitialized modifier missing from initialize function

#136 deluca-mike closed 2 years ago
1
Transfer return value is ignored

#135 deluca-mike closed 2 years ago
2
Token Transfers Are Not Handled Correctly

#134 itsmetechjay closed 2 years ago
2
Royalties do Not Support Fee-On-Transfer Tokens

#133 itsmetechjay closed 2 years ago
3
Use safeTransfer instead of transferFrom

#132 code423n4 closed 2 years ago
2
QA Report

#131 code423n4 opened 2 years ago
2
`RoyaltyVault.sol` is Not Equipped to Handle On-Chain Royalties From Secondary Sales

#130 code423n4 opened 2 years ago
1
Unsafe usage of transfer and transferFrom functions

#129 code423n4 closed 2 years ago
2
QA Report

#128 code423n4 opened 2 years ago
2
Anyone can change fee amount and receiver

#127 code423n4 closed 2 years ago
2
A large platformFee (>10000), would cause underflow during sendToSplitter (at RoyaltyVault.sol)

#126 code423n4 closed 2 years ago
1
Gas Optimizations

#125 code423n4 opened 2 years ago
0
QA Report

#124 code423n4 opened 2 years ago
0
Collection Owners Can Brick the `CoreCollection.sol` Contract by Preventing Token Transfers

#123 code423n4 closed 2 years ago
2
Collection Owners Can Reinitialize `CoreCollection.sol` and Mint Duplicate NFTs

#122 code423n4 closed 2 years ago
1
Duplicate NFTs Can Be Minted if `payableToken` Has a Callback Attached to it

#121 code423n4 opened 2 years ago
2
Gas Optimizations

#120 code423n4 opened 2 years ago
0
Gas Optimizations

#119 code423n4 opened 2 years ago
0
Gas Optimizations

#118 code423n4 closed 2 years ago
1
User can mint without paying if the token used doesn't revert on failure

#117 code423n4 closed 2 years ago
1
Any User Can Call `incrementWindow()` by Using a Spoofed Contract

#116 code423n4 closed 2 years ago
1
Possible problem when mintToken and the user wants to purchase a token

#115 code423n4 closed 2 years ago
1
Missing onlyUnInitialized modifier on initialize() function

#114 code423n4 closed 2 years ago
1
Gas Optimizations

#113 code423n4 opened 2 years ago
1
Add a timelock to `setPlatformFee()`

#112 code423n4 opened 2 years ago
1
Initializer can be called many times and change critical parameters in an existing collection

#111 code423n4 closed 2 years ago
1
QA Report

#110 code423n4 opened 2 years ago
2
One co-creator with a small share can get 100% of the funds in the splitter

#109 code423n4 closed 2 years ago
1
STORAGE COLLISION BETWEEN PROXY AND IMPLEMENTATION (LACK EIP 1967)

#108 code423n4 opened 2 years ago
3
No reentrancy guard on mint() function that has a callback

#107 code423n4 closed 2 years ago
1
QA Report

#106 code423n4 opened 2 years ago
2