code-423n4 / 2022-04-dualityfocus-findings

1 stars 0 forks source link

redeemfresh reentry #24

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/code-423n4/2022-04-dualityfocus/blob/f21ef7708c9335ee1996142e2581cb8714a525c9/contracts/compound_rari_fork/CToken.sol#L781-L785

Vulnerability details

Impact

Allmost the same as the borrowfresh func, should obey the check-effect-intereact pattern.

Proof of Concept

the same as borrow fresh

Tools Used

None

Recommended Mitigation Steps


        /* We write previously calculated values into storage */
        totalSupply = vars.totalSupplyNew;
        accountTokens[redeemer] = vars.accountTokensNew;

        doTransferOut(to, vars.redeemAmount);

0xdramaone commented 2 years ago

Duplicate of #17