code-423n4 / 2022-05-backd-findings

0 stars 0 forks source link

Upgraded Q -> M from 18 [1656705908645] #182

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #18 as Medium risk. The relevant finding follows:

Controlled swapRouter The FeeBurner contract sets the swapperRouter in the _addressProvider, so the owner can set any type of swapper, paths or pools, even malicious ones. Since there is no slippage defined in the FeeBurner contract itself, it could be that a swapperRouter returns 0 WETH, and keeps the sent tokens.

Affected source code:

FeeBurner.sol#L73

GalloDaSballo commented 2 years ago

Duplicate of https://github.com/code-423n4/2022-05-backd-findings/issues/113