search

code-423n4 / 2022-05-cudos-findings

1 stars 0 forks source link

no way to change the threshold #115

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/code-423n4/2022-05-cudos/blob/main/solidity/contracts/Gravity.sol#L276

Vulnerability details

It's impossible to change the threshold, thus it will prevent changing the configuration in some ways that require a different threshold

V-Staykov commented 2 years ago

Duplicate of #44

albertchon commented 2 years ago

As per @V-Staykov's comment on #44,

The only reason to change it would be to change the gravity modules way of operation and set a different threshold than the 2/3 there

this is by design.