code-423n4 / 2022-05-cudos-findings

1 stars 0 forks source link

QA Report #116

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/code-423n4/2022-05-cudos/blob/main/solidity/contracts/Gravity.sol#L661

Vulnerability details

use safe math or change solidity version to 8

V-Staykov commented 2 years ago

Duplicate of #39

albertchon commented 2 years ago

As per the comment on #39

because the cumulative power of all the validators is calculated proportionally and made sure on the cosmos module side that it will never overflow

Hence this is not a risk.

JeeberC4 commented 2 years ago

Creating this as warden's QA Report as judge downgraded issue. Preserving original title: addition can overflow in the constructor