Open code423n4 opened 2 years ago
Informationals:
[N01] whitelisted addresses are not being used, neither the modifier.
https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L65
https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L116
And there's a slight comment on the manageWhitelist function, an address on the whitelisted mapping can decide to set to false the whitelist "privilege" to another whitelist address. It may be better to be an admin role action.
[N02] confuse comment. https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L653
The signatures of the validators are not passed to the function.
Informationals:
[N01] whitelisted addresses are not being used, neither the modifier.
https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L65
https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L116
And there's a slight comment on the manageWhitelist function, an address on the whitelisted mapping can decide to set to false the whitelist "privilege" to another whitelist address. It may be better to be an admin role action.
[N02] confuse comment. https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L653
The signatures of the validators are not passed to the function.