search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded Q -> M from 201 [1656122644813] #458

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #201 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

Wrap transfer/transferFrom in require statements.

If choosing to not use something like openZepplins safeTransfer/safeTransferFrom it is good to add require checks to ensure transfers/tranferFroms revert in cast of failures. This is already done for all transfers/transferFroms in RubiconMarket.sol/BathHouse.sol but is missing in the following locations.

Duplicate of #316