search

code-423n4 / 2022-05-sturdy-findings

7 stars 3 forks source link

Upgraded Q -> H from 135 [1654503748167] #174

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #135 as High risk. The relevant finding follows:

HickupHH3 commented 2 years ago

Duplicate of #133.

"At LidoVault.sol, the slippage is hardcoded to 200 inside swapExactTokensForTokens() which yields to %2 and it most likely will revert during volatile market conditions and it will not be possible to save economic value of the assets by not being able to withdraw ETH."

Again, I am being lenient here because the warden should've substantiated more by pointing to recent market conditions of ETH / stETH rates, and refer to the 1% slippage in the general vault as another cause of failure of fund withdrawals. One can argue that the guideline of "demonstrating proper theory of how an issue could be exploited" was not met. However, the warden did point out the impact of failing withdrawals.

In the interest of fairness of my leniency for other issues raised, I will let this pass.