search

code-423n4 / 2022-08-foundation-findings

0 stars 0 forks source link

QA Report #262

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

HardlyDifficult commented 1 year ago

// Version cannot overflow 256 bits.

Agree, this was missed when we started packing. Will fix.

Inconsistent _DENOMINATOR

Disagree, although this is just code style. We went with the current approach in order to simplify the implementation below.

Potential for reentrancy in _tryUseFETHBalance

This is potentially valid, would need to create a POC to confirm. Based on other feedback, we have changed the implementation to confirm the balance after minting completes which will address the potential reentrancy concern here as well.

c4-sponsor commented 1 year ago

Added on behalf of @Simon-Busch

c4-sponsor commented 1 year ago

test || Action reverted on behalf of @Simon-Busch

c4-sponsor commented 1 year ago

Added on behalf of @Simon-Busch