search

code-423n4 / 2022-08-foundation-findings

0 stars 0 forks source link

Upgraded Q -> M from 239 [1661780295145] #291

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Judge has assessed an item in Issue #239 as Medium risk. The relevant finding follows:

HickupHH3 commented 1 year ago

Issue #1: OpenZeppelin recommends the usage of _safeMint() instead of _mint() since safeMint() checks whether a contract can handle ERC721 tokens. https://github.com/OpenZeppelin/openzeppelin-contracts/blob/2dc086563f2e51620ebc43d2237fc10ef201c4e6/contracts/token/ERC721/ERC721.sol#L270

If the user provides an address that can't handle ERC721 tokens when calling any of the corresponding mint functions the minted token might be lost which could potentially result in the user not being able to redeem the nft anymore.

HickupHH3 commented 1 year ago

dup of #183