search

code-423n4 / 2022-09-frax-findings

2 stars 1 forks source link

QA Report #266

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Use effects-Interactions Pattern

Set it to true before the deposit

Finding

File:  /src/frxETHMinter.sol

 activeValidators[pubKey] = true;

https://github.com/code-423n4/2022-09-frax/blob/main/src/frxETHMinter.sol#L151

Unnecessary checking for zero value

the deposit() on ERC4626 checked it on the top of the function

Finding

File:  /src/frxETHMinter.sol

 require(sfrxeth_recieved > 0, 'No sfrxETH was returned');

https://github.com/code-423n4/2022-09-frax/blob/main/src/frxETHMinter.sol#L79