Gas Optimizations

Array length should not be looked up in every iteration. It waste gas to read the length in each iteration of a for loop even if it is a memory or calldata array. 3 gas per read https://github.com/code-423n4/2022-09-quickswap/blob/main/src/core/contracts/libraries/DataStorage.sol#L307

1 instance.

USE CALLDATA INSTEAD OF MEMORY When a function with a memory array is called externally, the abi.decode() step has to use a for-loop to copy each index of the calldata to the memory index. Each iteration of this for-loop costs at least 60 gas (i.e. 60 * <mem_array>.length). Using calldata directly bypasses this loop.

3 INCREMENTS/DECREMENTS CAN BE UNCHECKED IN FOR-LOOP Consider wrapping an unchecked block here (around 25 gas per instance) https://github.com/code-423n4/2022-09-quickswap/blob/main/src/core/contracts/libraries/DataStorage.sol#L307

1 instance of this.

Default initialization One doesn't have to put i= 0 as the default would be uint/int is 0. https://github.com/code-423n4/2022-09-quickswap/blob/main/src/core/contracts/libraries/DataStorage.sol#L307 1 instance of this.
SPLITTING REQUIRE() STATEMENTS THAT USE && SAVES GAS - (SAVES 8 GAS PER &&) Instead of using the && operator in a single require statement to check multiple conditions,using multiple require statements with 1 condition per require statement will save 8 GAS per && https://github.com/code-423n4/2022-09-quickswap/blob/main/src/core/contracts/DataStorageOperator.sol#L46

3 instances of this.

Comparisons: != is more efficient that > in require (6 gas less) This != 0 cost less than compared to > 0 for uint in require statements. For uints the minimum value would be 0 and never a negative value. Since it cannot be a negative value, then the check > 0 is essentially checking that the value is not equal to 0 therefore >0 can be replaced with !=0 which saves gas.

6 instances of this

code-423n4 / 2022-09-quickswap-findings