code-423n4 / 2022-09-vtvl-findings

0 stars 0 forks source link

QA Report #483

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Non critical issues :

Comments with development questions are left in the repo. Example : https://github.com/code-423n4/2022-09-vtvl/blob/f68b7f3e61dad0d873b5b5a1e8126b839afeab5f/contracts/VTVLVesting.sol#L266

Lack of important events when withdrawing tokens : It's a best practice to emit an event when value is transferred. https://github.com/code-423n4/2022-09-vtvl/blob/f68b7f3e61dad0d873b5b5a1e8126b839afeab5f/contracts/VTVLVesting.sol#L446