Open code423n4 opened 2 years ago
Incorrect comments The comment max supply == 0 means mint at will. should be maxSupply_ == 0 means mint at will.
max supply == 0 means mint at will.
maxSupply_ == 0 means mint at will.
The comment However, if both are 0 we might have a valid scenario as well - user just wants to create a token but doesn't want to mint anything is incorrect. If both maxSupply_ and initialSupply_ are 0 then the user just wants to create a token but doesn't want to mint anything INITIALLY. It does indeed seem that this should be allowed, in which case the entire require-statement at line 27 can be removed.
However, if both are 0 we might have a valid scenario as well - user just wants to create a token but doesn't want to mint anything
maxSupply_
initialSupply_
Compiler version should be fixed
Instances: https://github.com/code-423n4/2022-09-vtvl/blob/f68b7f3e61dad0d873b5b5a1e8126b839afeab5f/contracts/token/VariableSupplyERC20Token.sol#L2
Incorrect comments The comment
max supply == 0 means mint at will.should bemaxSupply_ == 0 means mint at will.The comment
However, if both are 0 we might have a valid scenario as well - user just wants to create a token but doesn't want to mint anythingis incorrect. If bothmaxSupply_andinitialSupply_are 0 then the user just wants to create a token but doesn't want to mint anything INITIALLY. It does indeed seem that this should be allowed, in which case the entire require-statement at line 27 can be removed.Compiler version should be fixed
Instances: https://github.com/code-423n4/2022-09-vtvl/blob/f68b7f3e61dad0d873b5b5a1e8126b839afeab5f/contracts/token/VariableSupplyERC20Token.sol#L2