search

code-423n4 / 2023-03-zksync-findings

6 stars 1 forks source link

QA Report #172

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[LOW - 1] Any transaction sending more than 2**128 ETH will loose them

Invalid because ETH supply is way less

[LOW - 2] Dangerous function should be removed

L

[QA - 1] Unclear block gas limit

L

[QA - 2] Silent down-casting

Disputing from my current understanding

offset is the byte at which the data starts, so byte - 2 for a dynamic type will allow you to read the length of the calldata

I believe this should be refactorable to getting length, but I believe the sponsor applied their own compression scheme.

[QA - 3] Unhelpful revert message

NC

[QA - 4] Function name is not descriptive enough

Disputing

[QA - 5] No need for a "default" path which is unreachable

R

2L 1R 1NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c