search

code-423n4 / 2023-05-caviar-mitigation-contest-findings

0 stars 0 forks source link

Mitigation Confirmed for M-05 #40

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

The issue at hand has been successfully resolved with the current fix. Specifically, the _approveNfts function has been designed to exit before granting approval again if it has already been granted once, effectively eliminating the problem. Additionally, the _approveNfts function is used instead of a simple approval everywhere in the ethRouter contract so there cannot be a case where this check gets negated.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory