search

code-423n4 / 2023-05-caviar-mitigation-contest-findings

0 stars 0 forks source link

Mitigation Confirmed for M-10 #44

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

The mitigation of the wrong calculation is completely appropriate in my opinion. Now the change fees get calculated in a way that they reflect how many NFTs are actually getting changed instead of a low static number. The new business logic also adds a variable protocolChangeFeeRate in the factory contract that is used instead of the protocolFeeRate variable when calculating change and flash loan fees. This variable is also a 16-bit integer but it can hold a different value than the normal protocolFeeRate variable so the fees related to change and flash loan operations can be higher.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory