search

code-423n4 / 2024-03-saltyio-mitigation-findings

0 stars 0 forks source link

M-02 MitigationConfirmed #68

Open c4-bot-10 opened 8 months ago

c4-bot-10 commented 8 months ago

Lines of code

Vulnerability details

Comments

In the original implementation, if the external call of ICalledContract(ballot.address1).callFromDAO( ballot.number1 ) reverts, it could result in the CALL_CONTRACT ballot not being finalized.

Mitigation

commit 5f1a520 The mitigation wrapped callFromDAO() in a try/catch block. The CALL_CONTRACT ballot can be finalized no matter the external call callFromDAO() reverts or not. The original issue was resolved.

Conclusion

Confirmed

c4-judge commented 8 months ago

Picodes marked the issue as satisfactory