search

code-423n4 / 2024-04-revert-mitigation-findings

1 stars 1 forks source link

M-22 MitigationConfirmed #24

Open c4-bot-8 opened 4 months ago

c4-bot-8 commented 4 months ago

Lines of code

Vulnerability details

C4 issue

M-22: dailyDebtIncreaseLimitLeft is not updated in liquidate()

Comment

In the original implementation, function liquidate does not increase dailyDebtIncreaseLimitLeft like in function repay while it should because repaid/liquidated debt should be borrowed again.

Mitigation

PR #11 The mitigation code added liquidated debt to dailyDebtIncreaseLimitLeft:

dailyDebtIncreaseLimitLeft = dailyDebtIncreaseLimitLeft + state.debt;

The mitigation solved the original issue

Conclusion

LGTM

c4-judge commented 4 months ago

jhsagd76 marked the issue as satisfactory