EasyAuction implementations are now hardwired in the GnosisTrade contract implementation, which constitutes a good trade-off between:
assurance that the EasyAuction implementation can't be updated directly by the governance
at the same time flexibility in allowing the implementation to be updated via upgrades to a new GnosisTrade implementation, which is allowed and safely controlled by versionRegistry when set
The change therefore lifts the EasyAuction setting from a lower security that allows Governance to change it freely, to the same level that is given to contract upgrades, and this is consistent with all actions that Governance can take to avoid paying fees.
The EasyAuctionimplementation being used is now one deployed by the sponsor. This contract is identical to the original EasyAuction implementation and no issues were found with it or its deployment parameters.
The provided change fully fixes the finding Governance can bypass DAO fee through custom EasyAuction implementation without introducing regressions.
EasyAuction
implementations are now hardwired in theGnosisTrade
contract implementation, which constitutes a good trade-off between:EasyAuction
implementation can't be updated directly by the governanceGnosisTrade
implementation, which is allowed and safely controlled byversionRegistry
when setThe change therefore lifts the
EasyAuction
setting from a lower security that allows Governance to change it freely, to the same level that is given to contract upgrades, and this is consistent with all actions that Governance can take to avoid paying fees.The
EasyAuction
implementation being used is now one deployed by the sponsor. This contract is identical to the original EasyAuction implementation and no issues were found with it or its deployment parameters.